Handle the case where we have attributes set to null in the LDAP modu…

…le for all attributes
simplesamlphp · Sep 18, 2024 · 230bbdd · 230bbdd
1 parent 811cb91
commit 230bbdd
Showing 1 changed file with 16 additions and 8 deletions.
diff --git a/src/Auth/Source/X509userCert.php b/src/Auth/Source/X509userCert.php
@@ -191,10 +191,14 @@ public function authenticate(array &$state): void
 
         if ($this->ldapusercert === null) {
             // do not check for certificate match
-            $attributes = array_intersect_key(
-                $entry->getAttributes(),
-                array_fill_keys(array_values($this->ldapConfig->getArray('attributes')), null),
-            );
+            if (is_null($this->ldapConfig->getOptionalArray('attributes',null))) {
+                $attributes = $entry->getAttributes();
+            } else {
+                $attributes = array_intersect_key(
+                    $entry->getAttributes(),
+                    array_fill_keys(array_values($this->ldapConfig->getArray('attributes')), null),
+                );
+            }
 
             $state['Attributes'] = $attributes;
             $this->authSuccesful($state);
@@ -232,10 +236,14 @@ public function authenticate(array &$state): void
             }
 
             if ($ldap_cert_data === $client_cert_data) {
-                $attributes = array_intersect_key(
-                    $entry->getAttributes(),
-                    array_fill_keys(array_values($this->ldapConfig->getArray('attributes')), null),
-                );
+		        if (is_null($this->ldapConfig->getOptionalArray('attributes',null))) {
+                    $attributes = $entry->getAttributes();
+                } else {
+                    $attributes = array_intersect_key(
+                        $entry->getAttributes(),
+                        array_fill_keys(array_values($this->ldapConfig->getArray('attributes')), null),
+                    );
+                }
                 $state['Attributes'] = $attributes;
                 $this->authSuccesful($state);