Skip to content
This repository has been archived by the owner on Oct 17, 2022. It is now read-only.

Benchmarking improvements #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Benchmarking improvements #4

wants to merge 3 commits into from

Commits on Jun 30, 2020

  1. Benchmark this implementation against the standard library's 

    Two sets of benchmarks are now run, one with this validator and one
with std::str::from_utf8 (a thin, inlined wrapper around the internal
run_utf8_validation function). This commit also changes the benchmark
to use functions instead of macros, slightly improving readability.
    @milkey-mouse
    milkey-mouse committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    bec1eff View commit details
    Browse the repository at this point in the history

  2. Measure benchmark runtime in cycles per byte on x86

    @milkey-mouse
    milkey-mouse committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    903e2a2 View commit details
    Browse the repository at this point in the history

  3. Use str::from_utf8 in tests instead of String::from_utf8 

    There's no need to make a String (and allocate a new Vec) when the same
method is available on &str.
    @milkey-mouse
    milkey-mouse committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    8ea7586 View commit details
    Browse the repository at this point in the history