Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ToString to use original rather than foldedCase #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bergmark
Copy link
Member

@bergmark bergmark commented Sep 1, 2015

Is there a reason behind using foldedCase? It's unintuitive to me as e.g. toString . mk isn't the identity.

If we change this I think it calls for a major bump.

@hesselink
Copy link
Member

You added it ;) I think you're right, it's probably better to use original. As for laws, fromString . toString = id makes sense to me, but that one holds in either case. I think toString . fromString = id is too string, that removed any opportunity for normalization without storing the original string. So in the end I think this choice is just one of preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants