-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nix): Ignore many files when creating src #1255
Conversation
In response to #1231 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this.
Just a few question marks in my mind. See comments, plus more generally does this filter have any kind of wildcard/globbing/regex support? Could it accept a file list from another source / format? We now have include/exclude lists for quite a few purposes: git ignores, linting include / exclude, vendored libraries, autotools dist_files, docker builds, etc. Someday we're going to want to unify them a bit.
Sort of, but it's not that well developed, see: https://github.com/numtide/nix-filter#design-notes
Yes, we can read a list of files from another file, we can even read that list of files and ignore the file itself along.
I'm not against that, but to my view many of these exclude lists perhaps intersect but not match a lot since they serve different purposes. The sole purpose of this exclude list is to make the source directory of the build cleaner so that running I do see a reason to ignore both what's in the list here, and what's written in |
84f5d94
to
ef5d334
Compare
|
ef5d334
to
e5a3c33
Compare
No description provided.