Fixed issue where spaces in name of PPTX would cause it not to be found #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There,
This is my very first pull request on GitHub so I'm sorry if I'm not doing it the right way! You can also ignore all additions / deletions / changes except for the changes to src/main/java/org/sikuli/slides/api/io/PPTXSlidesReader.java.
I had a problem where this version of Sikuli Slides couldn't handle a PPTX with a space in its path name. I traced the problem to the part of the code that I changed. It seems that the original code was trying to look for the path with the spaces escaped using URL character escaping. This of course is not valid for the local file system. I change the code so that if the PPTX is actually on the local file system the 'URL' will be unencoded.
I'd like to help out with further bug fixing and enhancements to Sikuli Slides, so if you have any tips / comments regarding how we can work together and how I can make better pull requests I look forward to hearing from you.
Regards,
Andrew