Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed native undo/redo #676

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Fixed native undo/redo #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
990f61c
Fixed native undo/redo
byTimo May 24, 2023
0eb1509
Merge branch 'master' into native-undo-fix
Sigrsig Jun 29, 2023
d2b0243
uneeded .gitignore additions removed
Sigrsig Jun 29, 2023
87b8fa7
readded *.log to gitignore, was removed by accident
Sigrsig Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/seven-kangaroos-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-mentions": patch
---

Fixed native undo/redo in case the input was not focused before the operation
14 changes: 12 additions & 2 deletions src/MentionsInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,13 +517,23 @@ class MentionsInput extends React.Component {

let newPlainTextValue = ev.target.value

let selectionStartBefore = this.state.selectionStart;
if(selectionStartBefore == null) {
selectionStartBefore = ev.target.selectionStart;
}

let selectionEndBefore = this.state.selectionEnd;
if(selectionEndBefore == null) {
selectionEndBefore = ev.target.selectionEnd;
}

// Derive the new value to set by applying the local change in the textarea's plain text
let newValue = applyChangeToValue(
value,
newPlainTextValue,
{
selectionStartBefore: this.state.selectionStart,
selectionEndBefore: this.state.selectionEnd,
selectionStartBefore,
selectionEndBefore,
selectionEndAfter: ev.target.selectionEnd,
},
config
Expand Down