Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms overhaul (including several components) #1318

Open
wants to merge 244 commits into
base: main
Choose a base branch
from

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Jun 11, 2024

💡 What is the current behavior?

GitHub Issue Number: #

🆕 What is the new behavior?

Introduce new validation concept with new components:

  • ix-text-field
  • ix-number-field
  • ix-textarea-field
  • ix-date-field
  • ix-checkbox
  • ix-radio
  • ix-custom-field

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@AndreasBerliner AndreasBerliner dismissed their stale review September 13, 2024 06:39

Review only applied to latest changes regarding vue event handling

Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deploy Preview Deploy a preview instance of the documentation
Projects
None yet
7 participants