feat(core/menu-item): show tooltip on hover (#1200)

Co-authored-by: Lukas Maurer <[email protected]>
siemens · Apr 16, 2024 · 179ca17 · 179ca17
1 parent 7c13c7f
commit 179ca17
Show file tree

Hide file tree

Showing 118 changed files with 897 additions and 401 deletions.
diff --git a/.changeset/poor-cameras-give.md b/.changeset/poor-cameras-give.md
@@ -0,0 +1,8 @@
+---
+'@siemens/ix-react': minor
+'@siemens/ix': minor
+'@siemens/ix-vue': minor
+'@siemens/ix-angular': minor
+---
+
+feat(core/menu-item): show tooltip on hover
diff --git a/.github/workflows/deploy-gh-pages.yml b/.github/workflows/deploy-gh-pages.yml
@@ -12,7 +12,7 @@ concurrency: deploy-gh-pages-${{ github.ref }}
 
 jobs:
   deploy-gh-pages:
-    if: ${{ inputs.confirm_deployment == true }}
+    if: ${{ inputs.confirm_deployment == true && github.repository == 'siemens/ix' }}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout

diff --git a/.github/workflows/issue-workflow.yml b/.github/workflows/issue-workflow.yml
@@ -6,6 +6,7 @@ on:
 
 jobs:
   comment-workflow:
+    if: ${{ github.repository == 'siemens/ix' }}
     runs-on: ubuntu-latest
     steps:
 

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -17,6 +17,7 @@ on:
 jobs:
   deploy_nightly:
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'siemens/ix' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v3

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -10,6 +10,7 @@ concurrency: ${{ github.workflow }}-${{ github.ref }}
 
 jobs:
   release:
+    if: ${{ github.repository == 'siemens/ix' }}
     name: Release
     runs-on: ubuntu-latest
     steps:

diff --git a/packages/angular/src/components.ts b/packages/angular/src/components.ts
@@ -1506,14 +1506,14 @@ export declare interface IxMenuCategory extends Components.IxMenuCategory {}
 
 
 @ProxyCmp({
-  inputs: ['active', 'bottom', 'disabled', 'home', 'icon', 'notifications', 'tabIcon']
+  inputs: ['active', 'bottom', 'disabled', 'home', 'icon', 'label', 'notifications', 'tabIcon']
 })
 @Component({
   selector: 'ix-menu-item',
   changeDetection: ChangeDetectionStrategy.OnPush,
   template: '<ng-content></ng-content>',
   // eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
-  inputs: ['active', 'bottom', 'disabled', 'home', 'icon', 'notifications', 'tabIcon'],
+  inputs: ['active', 'bottom', 'disabled', 'home', 'icon', 'label', 'notifications', 'tabIcon'],
 })
 export class IxMenuItem {
   protected el: HTMLElement;

diff --git a/packages/core/component-doc.json b/packages/core/component-doc.json
@@ -400,17 +400,17 @@
         "ix-map-navigation"
       ],
       "dependencies": [
-        "ix-burger-menu",
+        "ix-menu-expand-icon",
         "ix-icon-button",
         "ix-dropdown"
       ],
       "dependencyGraph": {
         "ix-application-header": [
-          "ix-burger-menu",
+          "ix-menu-expand-icon",
           "ix-icon-button",
           "ix-dropdown"
         ],
-        "ix-burger-menu": [
+        "ix-menu-expand-icon": [
           "ix-icon-button",
           "ix-spinner"
         ],
@@ -620,11 +620,11 @@
           "ix-application-header"
         ],
         "ix-application-header": [
-          "ix-burger-menu",
+          "ix-menu-expand-icon",
           "ix-icon-button",
           "ix-dropdown"
         ],
-        "ix-burger-menu": [
+        "ix-menu-expand-icon": [
           "ix-icon-button",
           "ix-spinner"
         ],
@@ -7307,7 +7307,6 @@
       "encapsulation": "shadow",
       "dependents": [
         "ix-application-header",
-        "ix-burger-menu",
         "ix-card-list",
         "ix-category-filter",
         "ix-chip",
@@ -7324,6 +7323,7 @@
         "ix-menu",
         "ix-menu-about",
         "ix-menu-about-news",
+        "ix-menu-expand-icon",
         "ix-menu-settings",
         "ix-message-bar",
         "ix-modal-example",
@@ -7345,9 +7345,6 @@
         "ix-application-header": [
           "ix-icon-button"
         ],
-        "ix-burger-menu": [
-          "ix-icon-button"
-        ],
         "ix-card-list": [
           "ix-icon-button"
         ],
@@ -7396,6 +7393,9 @@
         "ix-menu-about-news": [
           "ix-icon-button"
         ],
+        "ix-menu-expand-icon": [
+          "ix-icon-button"
+        ],
         "ix-menu-settings": [
           "ix-icon-button"
         ],
@@ -8600,11 +8600,11 @@
           "ix-spinner"
         ],
         "ix-application-header": [
-          "ix-burger-menu",
+          "ix-menu-expand-icon",
           "ix-icon-button",
           "ix-dropdown"
         ],
-        "ix-burger-menu": [
+        "ix-menu-expand-icon": [
           "ix-icon-button",
           "ix-spinner"
         ]
@@ -9030,22 +9030,28 @@
       "encapsulation": "shadow",
       "dependents": [],
       "dependencies": [
-        "ix-burger-menu",
+        "ix-menu-expand-icon",
         "ix-icon-button",
         "ix-menu-item"
       ],
       "dependencyGraph": {
         "ix-menu": [
-          "ix-burger-menu",
+          "ix-menu-expand-icon",
           "ix-icon-button",
           "ix-menu-item"
         ],
-        "ix-burger-menu": [
+        "ix-menu-expand-icon": [
           "ix-icon-button",
           "ix-spinner"
         ],
         "ix-icon-button": [
           "ix-spinner"
+        ],
+        "ix-menu-item": [
+          "ix-tooltip"
+        ],
+        "ix-tooltip": [
+          "ix-typography"
         ]
       },
       "props": [
@@ -9418,7 +9424,12 @@
           "attr": "start-expanded",
           "reflectToAttr": false,
           "docs": "If set the menu will be expanded initially. This will only take effect at the breakpoint 'lg'.",
-          "docsTags": [],
+          "docsTags": [
+            {
+              "name": "since",
+              "text": "2.2.0"
+            }
+          ],
           "default": "false",
           "values": [
             {
@@ -10357,6 +10368,12 @@
           "ix-dropdown-item",
           "ix-typography",
           "ix-divider"
+        ],
+        "ix-menu-item": [
+          "ix-tooltip"
+        ],
+        "ix-tooltip": [
+          "ix-typography"
         ]
       },
       "props": [
@@ -10429,7 +10446,14 @@
       "styles": [],
       "slots": [],
       "parts": [],
-      "listeners": []
+      "listeners": [
+        {
+          "event": "closeOtherCategories",
+          "target": "window",
+          "capture": false,
+          "passive": false
+        }
+      ]
     },
     {
       "dirPath": "src/components/menu-item",
@@ -10452,8 +10476,16 @@
         "ix-menu",
         "ix-menu-category"
       ],
-      "dependencies": [],
+      "dependencies": [
+        "ix-tooltip"
+      ],
       "dependencyGraph": {
+        "ix-menu-item": [
+          "ix-tooltip"
+        ],
+        "ix-tooltip": [
+          "ix-typography"
+        ],
         "ix-menu": [
           "ix-menu-item"
         ],
@@ -10574,6 +10606,32 @@
           "optional": false,
           "required": false
         },
+        {
+          "name": "label",
+          "type": "string",
+          "complexType": {
+            "original": "string",
+            "resolved": "string",
+            "references": {}
+          },
+          "mutable": false,
+          "attr": "label",
+          "reflectToAttr": false,
+          "docs": "Label of the menu item. Will also be used as tooltip text",
+          "docsTags": [
+            {
+              "name": "since",
+              "text": "2.2.0"
+            }
+          ],
+          "values": [
+            {
+              "type": "string"
+            }
+          ],
+          "optional": false,
+          "required": false
+        },
         {
           "name": "notifications",
           "type": "number",
@@ -13562,11 +13620,11 @@
         "ix-application-switch-modal",
         "ix-avatar",
         "ix-breadcrumb-item",
-        "ix-burger-menu",
         "ix-button",
         "ix-category-filter",
         "ix-icon-button",
         "ix-icon-toggle-button",
+        "ix-menu-expand-icon",
         "ix-modal-loading",
         "ix-pagination",
         "ix-toggle-button",
@@ -13583,9 +13641,6 @@
         "ix-breadcrumb-item": [
           "ix-spinner"
         ],
-        "ix-burger-menu": [
-          "ix-spinner"
-        ],
         "ix-button": [
           "ix-spinner"
         ],
@@ -13598,6 +13653,9 @@
         "ix-icon-toggle-button": [
           "ix-spinner"
         ],
+        "ix-menu-expand-icon": [
+          "ix-spinner"
+        ],
         "ix-modal-loading": [
           "ix-spinner"
         ],
@@ -15788,6 +15846,7 @@
       ],
       "encapsulation": "shadow",
       "dependents": [
+        "ix-menu-item",
         "ix-slider"
       ],
       "dependencies": [
@@ -15797,25 +15856,43 @@
         "ix-tooltip": [
           "ix-typography"
         ],
+        "ix-menu-item": [
+          "ix-tooltip"
+        ],
         "ix-slider": [
           "ix-tooltip"
         ]
       },
       "props": [
         {
           "name": "for",
-          "type": "string",
+          "type": "HTMLElement | Promise<HTMLElement> | string",
           "complexType": {
-            "original": "string",
-            "resolved": "string",
-            "references": {}
+            "original": "string | HTMLElement | Promise<HTMLElement>",
+            "resolved": "HTMLElement | Promise<HTMLElement> | string",
+            "references": {
+              "HTMLElement": {
+                "location": "global",
+                "id": "global::HTMLElement"
+              },
+              "Promise": {
+                "location": "global",
+                "id": "global::Promise"
+              }
+            }
           },
           "mutable": false,
           "attr": "for",
           "reflectToAttr": false,
           "docs": "CSS selector for hover trigger element e.g. `for=\"[data-my-custom-select]\"`",
           "docsTags": [],
           "values": [
+            {
+              "type": "HTMLElement"
+            },
+            {
+              "type": "Promise<HTMLElement>"
+            },
             {
               "type": "string"
             }