Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling raised MatchExceptions in the Determiner Object and adding more adjective and adverb support #290

Closed
wants to merge 17 commits into from

Conversation

sundararajan-s
Copy link

Handles the issue regarding of a MatchException being raised by the Determiner Object by adding new cases and a new subclass for the handling 'both' #289.

@sundararajan-s sundararajan-s marked this pull request as ready for review August 29, 2020 11:53
@siddhartha-gadgil
Copy link
Owner

The diffs are too large so it is hard to tell what actually changed. For example, why should index.html have changed. More seriously, it seems that stuff was reformatted so that when a few lines are added, existing code is reformatted so not matched with the old one.

@siddhartha-gadgil
Copy link
Owner

A couple of points:

  • There is a .scalafmt.conf, so please reformat using scalafmt only (which is the standard).
  • Perhaps the problem was that earlier I had a different format. In that case it may be better to have separate commits with reformatting only.
  • It may not have been clear, but index.html is system generated. It should not be manually edited, but instead generated with Site.mkSite(). Please revert manual changes.

Signed-off-by: sundararajan-s <[email protected]>

# Conflicts:
#	docs/index.html
@sundararajan-s sundararajan-s changed the title Handling raised MatchExceptions in the Determiner Object Handling raised MatchExceptions in the Determiner Object and adding more adjective and adverb support Sep 2, 2020
@sundararajan-s
Copy link
Author

The diffs are too large so it is hard to tell what actually changed. For example, why should index.html have changed. More seriously, it seems that stuff was reformatted so that when a few lines are added, existing code is reformatted so not matched with the old one.

I think this was due to reformatting. I shall fix that.

A couple of points:

  • There is a .scalafmt.conf, so please reformat using scalafmt only (which is the standard).
  • Perhaps the problem was that earlier I had a different format. In that case it may be better to have separate commits with reformatting only.
  • It may not have been clear, but index.html is system generated. It should not be manually edited, but instead generated with Site.mkSite(). Please revert manual changes.

I shall do that.

@sundararajan-s
Copy link
Author

I shall redo this and create a different pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants