Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Schmir/key broadcaster #3

Closed
wants to merge 2 commits into from
Closed

Schmir/key broadcaster #3

wants to merge 2 commits into from

Conversation

schmir
Copy link
Contributor

@schmir schmir commented Jul 25, 2023

Require additional keyBroadcaster argument in addKeyperSet

Previously we only allowed the keyper set contract to broadcast eon keys. Now we pass an additional keyBroadcaster address when calling addKeyperSet.

Previously we only allowed the keyper set contract to broadcast eon keys. Now we
pass an additional keyBroadcaster address when calling addKeyperSet.
@schmir schmir requested a review from jannikluhn July 25, 2023 09:35
@jannikluhn
Copy link
Contributor

I think the broadcaster address would fit better into the keyper contract than into the manager contract. In some sense, it's an additional property of the keyper set similar to the threshold.

@schmir
Copy link
Contributor Author

schmir commented Jul 27, 2023

I think the broadcaster address would fit better into the keyper contract than into the manager contract. In some sense, it's an additional property of the keyper set similar to the threshold.

I am fine with changing that. I'd argue that the same is true for the activation slot. Let's discuss this in the daily.

@schmir
Copy link
Contributor Author

schmir commented Jul 27, 2023

Replaced by #4

@schmir schmir closed this Jul 27, 2023
@schmir schmir deleted the schmir/key-broadcaster branch August 15, 2023 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants