Fix buffer rotation creation in Screencast example #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogo4405
force-pushed
the
main
branch
2 times, most recently
from
6cf677a
to
5f95e3f
Compare
shogo4405
requested changes
Jun 30, 2024
There was a problem hiding this comment.
Simply enabling it might make it look buggy to first-time users. The default is set to landscape and trim mode, so when starting a vertical broadcast, the top and bottom get cut off. I think the following measures are necessary:
- Set videoSettings.scaleMode to letterBox.
- Allow it to be turned on/off with a flag or similar setting.
|
Updated, please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This PR fixes initialization of the buffer rotator in Screencast example.
Type of change