Switch modifier order.md

132 - Switch modifier order

BPool functions often use modifiers in the following order: _logs_ _lock_ Because _lock_is a reentrancy guard, it should take precedence over _logs.

Recommendation:

Place _lock_ before other modifiers; ensuring it is the very first and very last thing to run when a function is called.

---

Slide Screenshot

---

Slide Text

• ConsenSys Audit Balancer Finding 5.4
• Ordering
• Modifier Ordering
• Reentrancy Guard
• Modifier Orde: L -> R

---

References

• Youtube Reference
• ConsenSys's Audit of Balancer Finance

---

Tags