Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement process:NumFDs for Windows #1712

Merged
merged 2 commits into from
Sep 24, 2024
Merged

implement process:NumFDs for Windows #1712

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbc32af
implement NumFDs for Windows
al-online Sep 19, 2024
462736c
add comment for NumFDsWithContext
al-online Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion process/process_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ var (
procGetPriorityClass = common.Modkernel32.NewProc("GetPriorityClass")
procGetProcessIoCounters = common.Modkernel32.NewProc("GetProcessIoCounters")
procGetNativeSystemInfo = common.Modkernel32.NewProc("GetNativeSystemInfo")
procGetProcessHandleCount = common.Modkernel32.NewProc("GetProcessHandleCount")

processorArchitecture uint
)
Expand Down Expand Up @@ -548,8 +549,21 @@ func (p *Process) NumCtxSwitchesWithContext(ctx context.Context) (*NumCtxSwitche
return nil, common.ErrNotImplementedError
}

// NumFDsWithContext returns the number of handles for a process on Windows,
// not the number of file descriptors (FDs).
func (p *Process) NumFDsWithContext(ctx context.Context) (int32, error) {
return 0, common.ErrNotImplementedError
handle, err := windows.OpenProcess(processQueryInformation, false, uint32(p.Pid))
if err != nil {
return 0, err
}
defer windows.CloseHandle(handle)

var handleCount uint32
ret, _, err := procGetProcessHandleCount.Call(uintptr(handle), uintptr(unsafe.Pointer(&handleCount)))
if ret == 0 {
return 0, err
}
return int32(handleCount), nil
}

func (p *Process) NumThreadsWithContext(ctx context.Context) (int32, error) {
Expand Down
Loading