Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Interface for Configuration #7

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

solvingproblemswithtechnology
  • I added a WinForms Core project so we have an interface to change OBS settings.
  • Started to generalizing OBS and PowerPoint interaction so maybe we can add support for google docs and others.
  • Added a GitHub Action to generate a release on v* tags.
    • I had to remove the COMReference and use a Good Old Nuget™. I had many problems with this.

@shanselman
Copy link
Owner

This looks amazing! Given mine is a little console app and this is really a re-write or complete refactoring, how about this?

Take your Fork and rename something like PowerPointToOBS-WinForms or something and I'll LINK to you from my readme? That way there's two - console and forms?

@solvingproblemswithtechnology
Copy link
Author

Thank you!

Given that the idea is yours and you also did a video (which I enjoyed) I think it's fine to contribute a little. I had a similar WinForms app (also with an action) so It was fast to add it to the project. Also, it will be way more useful in your repo.

I like the idea of having both, a Console and a Form. Maybe can we use https://github.com/natemcmaster/CommandLineUtils or something like that? And create a single executable?

Anyway, go ahead and merge it if you like, that's the spirit of open source :)

P.D.: Sorry for the english :)

@shanselman
Copy link
Owner

I don't know how to make an app that is both WinForms and Console. Maybe a second project in this solution?
Perdon por mi español ;)

@solvingproblemswithtechnology
Copy link
Author

Hi!

Merge the PR (if you like) and I'll do another one rebasing the new code and with the Console+WinForms project.

@solvingproblemswithtechnology
Copy link
Author

I updated with:

  • Brand new console app using https://github.com/natemcmaster/CommandLineUtils
    • Can use the --help option to see all the options.
    • Can use --no-gui to run the app without gui.
    • Added DI and standard logging.
  • Converting the winforms project to dll
  • Added dotnet warp to generate the release in github action.
  • Added the start/finish OBS command.
  • ==> Created a project so I can have the COM Reference embed in the dll. This allows using the dotnet cli instead of msbuild.
    • The nuget worked until I cleaned the solution, so I had to do this thing. Anyway, is a good way for managing interops.

@shanselman My only concern now is about naming these projects :) Naming is hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants