Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added intervalMultiplier #263

Closed
wants to merge 1 commit into from
Closed

Added intervalMultiplier #263

wants to merge 1 commit into from

Conversation

foxjazz
Copy link

@foxjazz foxjazz commented Aug 16, 2022

Added a multiplier to the interval option

@nblumhardt
Copy link
Member

Thanks for the suggestion. It's not likely that we'll add this feature at this point, though hopefully something you can apply and maintain via a downstream fork without too much trouble.

@bartelink
Copy link
Member

bartelink commented Oct 19, 2023

Thanks for taking the time to supply a PR demonstrating the idea - I appreciate the effort, and it's a long way from a drive by "can you add feature X already" comment.

However, I'm spring cleaning the issues and PRs list, and I feel that sadly the best thing to do here is to be cruel to be kind and close this for now.

See #298 (comment) for my reasoning

#243 will be the tracking issue for the general need/desire for a feature in this space

TL;DR

  • The high level approach of using an enum for the rolling interval is settled for now
  • multipliers and/or other variations to naming is not likely to happen in the near term
  • any resolution to the above should involve:
    1. writing up a detailed proposal as to how the facility would work
    2. ideally, a prototype, or links to a working fork that implements something very close to the proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants