Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject Empty path values #258

Closed
wants to merge 4 commits into from
Closed

Reject Empty path values #258

wants to merge 4 commits into from

Commits on Jun 29, 2022

  1. Use Path.GetFullPath() to resolve the full path of the input path. 

    Note: I also changed a few string == null checks to call string.IsNullOrEmpty() so that empty strings also throw (as I think those are error cases as well).

Fixes serilog#257.
    @AraHaan
    AraHaan authored Jun 29, 2022
    Configuration menu
    Copy the full SHA
    64f8e1b View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Looks like the only places where the issue is is FileSink and SharedFileSink.
    @AraHaan
    AraHaan authored Jun 29, 2022
    Configuration menu
    Copy the full SHA
    fc99f80 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Use ArgumentException instead of ArgumentNullException with IsNullOrE… 

    …mpty.
    @AraHaan
    AraHaan authored Jun 30, 2022
    Configuration menu
    Copy the full SHA
    83f4970 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Apply suggestions from code review

    @AraHaan
    AraHaan authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    19e0df1 View commit details
    Browse the repository at this point in the history