perf: avoid creating unused StepEventBuses (#3544)

serenity-bdd · Sep 24, 2024 · 6fc140c · 6fc140c
1 parent d8d2925
commit 6fc140c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/serenity-core/src/main/java/net/thucydides/core/steps/StepEventBus.java b/serenity-core/src/main/java/net/thucydides/core/steps/StepEventBus.java
@@ -107,9 +107,8 @@ public static StepEventBus eventBusFor(Object key) {
         if (key == null) {
             return new SilentEventBus(ConfiguredEnvironment.getEnvironmentVariables());
         }
-        STICKY_EVENT_BUSES.putIfAbsent(key, new StepEventBus(ConfiguredEnvironment.getEnvironmentVariables(),
-                ConfiguredEnvironment.getConfiguration()));
-        return STICKY_EVENT_BUSES.get(key);
+        return STICKY_EVENT_BUSES.computeIfAbsent(key, (unused) -> new StepEventBus(
+                ConfiguredEnvironment.getEnvironmentVariables(), ConfiguredEnvironment.getConfiguration()));
     }
 
     public static void setCurrentBusToEventBusFor(Object key) {