✨dynamic position of invalid vote option (#336)

Parent Issue: sequentech/epi#119
sequentech · Jun 27, 2023 · 7cc39ee · 7cc39ee
1 parent 663abf9
commit 7cc39ee
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 2 deletions.
diff --git a/avBooth/review-ballot-v2-directive/review-ballot-v2-directive.html b/avBooth/review-ballot-v2-directive/review-ballot-v2-directive.html
@@ -41,6 +41,24 @@ <h1 aria-level="2" class="text-brand-success question-title">
     <div 
       class="question-answers text-left"
     >
+      <div 
+        class="invalid-vote-col"
+        ng-class="{'extra-invalid-vote-space': question.hasCategories}"
+        ng-if="!!markedAsInvalid(question) && 'top' === question.invalidVoteAnswer.position"
+      >
+        <div
+          avb-simultaneous-question-answer-v2
+          answer="question.invalidVoteAnswer"
+          question="question"
+          is-invalid-vote-answer="true"
+          toggle-select-item="toggleSelectItem"
+          toggle-select-item-cumulative="toggleSelectItemCumulative"
+          cumulative-checks="cumulativeChecks"
+          hide-check="true"
+          read-only="true"
+        >
+        </div>
+      </div>
       <div class="categories" ng-if="question.hasCategories">
           <div
             ng-repeat="category in question.categories"
@@ -82,7 +100,7 @@ <h1 aria-level="2" class="text-brand-success question-title">
       <div 
         class="invalid-vote-col"
         ng-class="{'extra-invalid-vote-space': question.hasCategories}"
-        ng-if="!!markedAsInvalid(question)"
+        ng-if="!!markedAsInvalid(question) && 'bottom' === question.invalidVoteAnswer.position"
       >
         <div
           avb-simultaneous-question-answer-v2

diff --git a/...imultaneous-questions-v2-screen-directive/simultaneous-questions-v2-screen-directive.html b/...imultaneous-questions-v2-screen-directive/simultaneous-questions-v2-screen-directive.html
@@ -49,6 +49,24 @@ <h2 class="question-title" aria-level="2" ng-bind-html="question.title">
 
     <!-- QUESTION OPTIONS START -->
 
+    <div 
+      class="invalid-vote-col"
+      ng-class="{'extra-invalid-vote-space': question.hasCategories}"
+      ng-if="!!question.invalidVoteAnswer && 'top' === question.invalidVoteAnswer.position"
+    >
+      <div 
+        avb-simultaneous-question-answer-v2
+        answer="question.invalidVoteAnswer"
+        question="question"
+        is-invalid-vote-answer="true"
+        toggle-select-item="toggleSelectItem"
+        toggle-select-item-cumulative="toggleSelectItemCumulative"
+        cumulative-checks="cumulativeChecks"
+        hide-check="false"
+      >
+      </div>
+    </div>
+
     <div class="categories" ng-if="question.hasCategories">
         <div
           ng-repeat="category in question.categories"
@@ -95,7 +113,7 @@ <h2 class="question-title" aria-level="2" ng-bind-html="question.title">
     <div 
       class="invalid-vote-col"
       ng-class="{'extra-invalid-vote-space': question.hasCategories}"
-      ng-if="!!question.invalidVoteAnswer"
+      ng-if="!!question.invalidVoteAnswer && 'bottom' === question.invalidVoteAnswer.position"
     >
       <div 
         avb-simultaneous-question-answer-v2

diff --git a/.../simultaneous-questions-v2-screen-directive/simultaneous-questions-v2-screen-directive.js b/.../simultaneous-questions-v2-screen-directive/simultaneous-questions-v2-screen-directive.js
@@ -276,6 +276,11 @@ angular.module('avBooth')
                 return ErrorCheckerGeneratorService.hasUrl(answer.urls, 'invalidVoteFlag', 'true'); 
               }
             );
+
+            if (question.invalidVoteAnswer) {
+              var top = ErrorCheckerGeneratorService.hasUrl(question.invalidVoteAnswer.urls, 'positionFlag', 'top');
+              question.invalidVoteAnswer.position = top ? 'top' : 'bottom';
+            }
           }
         );