🐞 Write-in issues (#459) (#460)

Parent issue: sequentech/meta#1670
sequentech · Aug 8, 2024 · 74783dd · 74783dd
1 parent ca63874
commit 74783dd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/avBooth/error-checker-generator-service.js b/avBooth/error-checker-generator-service.js
@@ -457,22 +457,23 @@ angular.module('avUi')
                   return true;
                 }
 
-                var foundField = question.answers
+                var foundFields = question.answers
                   // only write-in questions
                   .filter(function (answer) {
                     return service.hasUrl(answer.urls, 'isWriteIn', 'true') &&
                       answer.selected > -1 &&
                       _.isObject(answer.writeInFields);
                   })
                   // get write-in fields
-                  .map(function (answer) { return Object.values(answer.writeInFields); })
-                  .flat()
-                  .find(function (field) {
-                    // check field min restriction against value
-                    return _.isString(field.value) && field.value.length < field.min;
-                  });
-
-                  return !foundField;
+                  .map(function (answer) { 
+                    return Object.values(answer.writeInFields)
+                    .find(function (field) {
+                      // check field min restriction against value
+                      return (_.isString(field.value) && field.value.length < field.min) || (answer.text && field.min && !field.value);
+                    });
+                   })
+                   .filter(value => value);
+                  return 0 === foundFields.length;
               },
               postfix: "-writein-field-min-length"
             },

diff --git a/.../simultaneous-question-answer-v2-directive/simultaneous-question-answer-v2-directive.html b/.../simultaneous-question-answer-v2-directive/simultaneous-question-answer-v2-directive.html
@@ -106,7 +106,7 @@
               type="text"
               ng-readonly="!!hideCheck()"
               class="form-control write-in-extra-field-input"
-              ng-class="{'invalid': (field.value && field.min && field.value.length < field.min) || (field.value && field.max && field.value.length > field.max)}"
+              ng-class="{'invalid': (answer.text && !field.value && field.min) ||  (field.value && field.min && field.value.length < field.min) || (field.value && field.max && field.value.length > field.max)}"
               autocomplete="off"
               id="question_{{question.index}}_answer_{{answer.id}}_{{field.id}}"
               placeholder="{{field | customI18n: 'placeholder'}}"