Punycode speed improvements #20

dlecocq · 2016-07-28T23:45:31Z

I had this hanging around on a branch, and I figured I should pull it forward now rather than let linger. A rough benchmark using the input "http://日本.co.jp" "/page":

Old:
Benchmarking parse + punycode with 1000000 per run:
  Average: 1043.73 ms
     Rate: 958.101 k-iter / s
Benchmarking punycode + unpunycode with 1000000 per run:
  Average: 1566.77 ms
     Rate: 638.256 k-iter / s

New:
Benchmarking parse + punycode with 1000000 per run:
  Average: 727.279 ms
     Rate: 1374.99 k-iter / s
Benchmarking punycode + unpunycode with 1000000 per run:
  Average: 946.035 ms
     Rate: 1057.04 k-iter / s

@b4hand @tammybailey @lindseyreno

b4hand · 2016-08-02T18:31:36Z

src/punycode.cpp

@@ -10,6 +10,16 @@ namespace Url

    std::string& Punycode::encode(std::string& str)
    {
+        std::string output;
+        encode(output, str.cbegin(), str.cend());
+        str.assign(output);


For C++, I'd just use the assignment operator. I don't know if this has been rebased to include that change or not.

b4hand · 2016-08-03T00:42:23Z

src/punycode.cpp

+    {
+        std::string output;
+        decode(output, str.cbegin(), str.cend());
+        str.assign(output);


Same thing about assignment operator.

b4hand reviewed Aug 2, 2016
View reviewed changes

Dan Lecocq added 2 commits August 2, 2016 15:27

Add a benchmark for punycode -> unpunycode round trip.

87c3476

Avoid additional string allocations when punycoding.

9f454eb

dlecocq force-pushed the dan/punycode-speed-improvements branch from 8f10f02 to 9f454eb Compare August 2, 2016 22:33

b4hand reviewed Aug 3, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Punycode speed improvements #20

Punycode speed improvements #20

dlecocq commented Jul 28, 2016

b4hand Aug 2, 2016

b4hand Aug 3, 2016

Punycode speed improvements #20

Are you sure you want to change the base?

Punycode speed improvements #20

Conversation

dlecocq commented Jul 28, 2016

b4hand Aug 2, 2016

Choose a reason for hiding this comment

b4hand Aug 3, 2016

Choose a reason for hiding this comment