-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: vendor pro binary with vscode #164
Merged
ajbt200128
merged 27 commits into
master
from
austin/saf-1199-vendor-pro-binary-with-vscode
Aug 21, 2024
Merged
chore: vendor pro binary with vscode #164
ajbt200128
merged 27 commits into
master
from
austin/saf-1199-vendor-pro-binary-with-vscode
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok looks like I just need to add a role for this repo and CI should pass |
Not sure what's up with the GHA linting action failure tho |
tagging @tpetr since he is a much higher level GHA/AWS wizard than me |
ajbt200128
force-pushed
the
austin/saf-1199-vendor-pro-binary-with-vscode
branch
from
August 16, 2024 20:26
6f6df54
to
86dd54c
Compare
tpetr
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda glossed over lsp.ts
but LGTM after comments are addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
I manually released a pre-release version (1.8.3) and manually checked it on multiple platforms (linux, macos)
PR checklist:
If you're unsure about any of this, please see: