Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vendor pro binary with vscode #164

Merged
merged 27 commits into from
Aug 21, 2024

Conversation

ajbt200128
Copy link
Contributor

@ajbt200128 ajbt200128 commented Aug 16, 2024

Test plan

I manually released a pre-release version (1.8.3) and manually checked it on multiple platforms (linux, macos)

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@ajbt200128
Copy link
Contributor Author

Ok looks like I just need to add a role for this repo and CI should pass

@ajbt200128
Copy link
Contributor Author

ajbt200128 commented Aug 16, 2024

Not sure what's up with the GHA linting action failure tho

@ajbt200128 ajbt200128 requested a review from tpetr August 16, 2024 20:04
@ajbt200128
Copy link
Contributor Author

tagging @tpetr since he is a much higher level GHA/AWS wizard than me

@ajbt200128 ajbt200128 force-pushed the austin/saf-1199-vendor-pro-binary-with-vscode branch from 6f6df54 to 86dd54c Compare August 16, 2024 20:26
Copy link
Contributor

@tpetr tpetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda glossed over lsp.ts but LGTM after comments are addressed

.github/workflows/publish.yaml Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
download-lspjs.sh Outdated Show resolved Hide resolved
download-lspjs.sh Outdated Show resolved Hide resolved
src/lsp.ts Show resolved Hide resolved
@ajbt200128 ajbt200128 merged commit 172df53 into master Aug 21, 2024
10 checks passed
@ajbt200128 ajbt200128 deleted the austin/saf-1199-vendor-pro-binary-with-vscode branch August 21, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants