Push raising error message

.github/workflows/gem-push.yml

@@ -15,7 +15,7 @@ jobs:
       packages: write
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

.github/workflows/ruby.yml

@@ -22,11 +22,15 @@ jobs:
         ruby-version: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2']
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: true # runs 'bundle install' and caches installed gems automatically
     - name: Run tests
       run: bundle exec rake
+    - name: Upload coverage reports to Codecov
+      uses: codecov/[email protected]
+      env:
+        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

Gemfile

@@ -1,2 +1,5 @@
 source 'http://rubygems.org'
 gemspec
+
+gem 'simplecov'
+gem 'simplecov-cobertura'

analytics-ruby.gemspec

@@ -27,5 +27,4 @@ Gem::Specification.new do |spec|
     spec.add_development_dependency 'oj', '~> 3.6.2'
   end
   spec.add_development_dependency 'rubocop', '~> 1.0'
-  spec.add_development_dependency 'codecov', '~> 0.6'
 end

lib/segment/analytics/message_batch.rb

@@ -29,6 +29,7 @@
         message_json_size = message_json.bytesize
         if message_too_big?(message_json_size)
           logger.error('a message exceeded the maximum allowed size')
+          raise JSONGenerationError, 'Message Exceeded Maximum Allowed Size'
         else
           @messages << message
           @json_size += message_json_size + 1 # One byte for the comma

spec/segment/analytics/message_batch_spec.rb

@@ -9,16 +9,21 @@ class Analytics
 
       describe '#<<' do
         it 'appends messages' do
+          expect(subject.length).to eq(0)
+
           subject << { 'a' => 'b' }
+
           expect(subject.length).to eq(1)
         end
 
         it 'rejects messages that exceed the maximum allowed size' do
           max_bytes = Defaults::Message::MAX_BYTES
           message = { 'a' => 'b' * max_bytes }
 
-          subject << message
           expect(subject.length).to eq(0)
+
+          expect { subject << message }.to raise_error(MessageBatch::JSONGenerationError)
+            .with_message('Message Exceeded Maximum Allowed Size')
         end
       end
 

spec/spec_helper.rb

@@ -1,10 +1,9 @@
 # frozen_string_literal: true
 
-# https://github.com/codecov/codecov-ruby#usage
 require 'simplecov'
 SimpleCov.start
-require 'codecov'
-SimpleCov.formatter = SimpleCov::Formatter::Codecov
+require 'simplecov-cobertura'
+SimpleCov.formatter = SimpleCov::Formatter::CoberturaFormatter
 
 require 'segment/analytics'
 require 'active_support/time'