Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All classes have public init methods, so they can be used from outside the module #32

Merged
merged 3 commits into from
Aug 28, 2024
Merged

All classes have public init methods, so they can be used from outside the module #32

merged 3 commits into from
Aug 28, 2024

Conversation

mroloux
Copy link
Member

@mroloux mroloux commented Aug 26, 2024

This fixes errors such as

Screenshot 2024-08-26 at 13 24 33

@mroloux
Copy link
Member Author

mroloux commented Aug 26, 2024

All classes should have public init methods, so they can be used from outside the module

Base automatically changed from matti/fix-justbridge-memory-leak-part-2 to master August 26, 2024 18:14
@mroloux mroloux merged commit 92d0b01 into master Aug 28, 2024
1 check passed
@mroloux mroloux deleted the matti/all-classes-public-inits branch August 28, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bverbeken bverbeken bverbeken approved these changes

@schaloner schaloner Awaiting requested review from schaloner

@PabloNeirotti PabloNeirotti Awaiting requested review from PabloNeirotti

@mortendevold mortendevold Awaiting requested review from mortendevold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroloux @bverbeken