Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError if _initialize_models called with locales set on table #2233

Merged
merged 2 commits into from
Sep 19, 2024
Merged

TypeError if _initialize_models called with locales set on table #2233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d7f28
Use locales set in _table_parameters
frances-h Sep 19, 2024
468633d
Use different locale
frances-h Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdv/multi_table/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,10 @@ def _set_temp_numpy_seed(self):
def _initialize_models(self):
with disable_single_table_logger():
for table_name, table_metadata in self.metadata.tables.items():
synthesizer_parameters = self._table_parameters.get(table_name, {})
synthesizer_parameters = {'locales': self.locales}
synthesizer_parameters.update(self._table_parameters.get(table_name, {}))
self._table_synthesizers[table_name] = self._synthesizer(
metadata=table_metadata, locales=self.locales, **synthesizer_parameters
metadata=table_metadata, **synthesizer_parameters
)
self._table_synthesizers[table_name]._data_processor.table_name = table_name

Expand Down
6 changes: 4 additions & 2 deletions tests/unit/multi_table/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ def test__initialize_models(self):
locales = ['en_CA', 'fr_CA']
instance = Mock()
instance._table_synthesizers = {}
instance._table_parameters = {'nesreca': {'default_distribution': 'gamma'}}
instance._table_parameters = {
'nesreca': {'default_distribution': 'gamma', 'locales': ['en_US']},
}
instance.locales = locales
instance.metadata = get_multi_table_metadata()

Expand All @@ -57,7 +59,7 @@ def test__initialize_models(self):
call(
metadata=instance.metadata.tables['nesreca'],
default_distribution='gamma',
locales=locales,
locales=['en_US'],
),
call(metadata=instance.metadata.tables['oseba'], locales=locales),
call(metadata=instance.metadata.tables['upravna_enota'], locales=locales),
Expand Down
Loading