Improve usage of detect_from_dataframes function
#2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
changed the title
detect_from_dataframes function
amontanez24
force-pushed
the
issue-2214-detect-from-dataframes
branch
from
048ec5a
to
cef7ec4
Compare
rwedge
reviewed
Sep 12, 2024
tests/unit/metadata/test_metadata.py
Outdated
| data = {'guests': guests_table, 'hotels': hotels_table} | ||
|
|
||
| # Run | ||
| Metadata.detect_from_dataframes(data) |
There was a problem hiding this comment.
should we also test the returned value?
There was a problem hiding this comment.
yes, good catch!
rwedge
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #2214
CU-86b23k3j9