Fix circular relationships validation #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
force-pushed
the
fix-circular-relationships
branch
2 times, most recently
from
e4385f8
to
28c4ab2
Compare
fealho
force-pushed
the
fix-circular-relationships
branch
from
28c4ab2
to
6f48f5c
Compare
frances-h
approved these changes
Sep 5, 2024
amontanez24
reviewed
Sep 6, 2024
sdv/metadata/multi_table.py
Outdated
| @@ -138,7 +138,7 @@ def _validate_circular_relationships( | |||
|
|
|||
| for child in children: | |||
| if child in parents: | |||
There was a problem hiding this comment.
minor: can we rename parents to visited? I was confused reading this thinking that we were checking the parents of only the current node, when this list actually keeps growing.
amontanez24
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b21jrjd, Resolve #2205.