Add warnings that were suggested from metadata bughunt #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
approved these changes
Aug 30, 2024
| @@ -409,6 +409,8 @@ def update_columns(self, table_name, column_names, **kwargs): | |||
| **kwargs: | |||
| Any key word arguments that describe metadata for the columns. | |||
| """ | |||
| if not isinstance(column_names, list): | |||
There was a problem hiding this comment.
This wouldn't work for tuples and other list-like objects, something like pandas.api.types is_list_like could handle those.
If that's expected then you can leave as is.
There was a problem hiding this comment.
I think that's expected. Don't imagine a user putting in something more complicated than a list of strings and it's easy enough to convert.
amontanez24
reviewed
Sep 3, 2024
Comment on lines
+80
to
+81
| metadata_dict = {'tables': {table_name: table_metadata.to_dict()}} | ||
| metadata = Metadata.load_from_dict(metadata_dict) |
There was a problem hiding this comment.
No it was causing the single table metadata name to be missing since it gave it a default table (it was in a SingleTableMetadata format)
amontanez24
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the remaining usability issues by adding warnings to let the user know that they will get a default table name.
Also add errors to prevent the user from adding invalid
SingleTableMetadataarguments intoMetadata