Rename file_path to filepath parameter in ExcelHandler #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajohn4747
approved these changes
Jun 12, 2024
rwedge
approved these changes
Jun 12, 2024
Yeah. This feature is listed as in beta in our docs, so we're taking some liberty with how much we can change it. Also in our docs we specify that our docs are the source of truth for the API. So if the docs show one thing and the code is another, we've been treating that as a "bug". In this case the docs were changed but then we agreed to change it back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2055
CU-86b0vmmft