Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the saving of a temp file unless specified #2053

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #2042
CU-86b0p02f3

Remove the saving of a temp file during a synthesizer sample unless the user provides an output filepath.

@lajohn4747 lajohn4747 requested a review from a team as a code owner June 11, 2024 15:59
@sdv-team
Copy link
Contributor

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small doc comments but after that looks good!

sdv/lite/single_table.py Outdated Show resolved Hide resolved
sdv/lite/single_table.py Outdated Show resolved Hide resolved
sdv/single_table/base.py Outdated Show resolved Hide resolved
sdv/single_table/base.py Outdated Show resolved Hide resolved
@lajohn4747 lajohn4747 merged commit 71b9d03 into main Jun 12, 2024
39 checks passed
@lajohn4747 lajohn4747 deleted the issue_2042_no_temp_file_sample branch June 12, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If no filepath is provided, do not create a file during sample
4 participants