Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for simple PARSynthesizer constraints #2044

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Jun 3, 2024

resolves #1936
CU-86b04v6vb

Allow for constraints for PARSynthesizer but only for select cases:

  • You can only use a constraint for columns that are all contextual, or all non-contextual
  • You cannot supply multiple overlapping constraints (that is 2 constraints that each independently act on the same column)
  • You cannot use it for custom constraints (for now, as it is complicated with a custom constraint to determine whether points 1 and 2 can be met).

@lajohn4747 lajohn4747 requested a review from a team as a code owner June 3, 2024 23:29
@sdv-team
Copy link
Contributor

sdv-team commented Jun 3, 2024

Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an integration test as well?

@lajohn4747 lajohn4747 requested a review from frances-h June 5, 2024 16:03
sdv/sequential/par.py Show resolved Hide resolved
sdv/sequential/par.py Show resolved Hide resolved
@lajohn4747 lajohn4747 merged commit 2a7e348 into main Jun 7, 2024
39 checks passed
@lajohn4747 lajohn4747 deleted the issue_1936_par_constraints branch June 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow constraints in PARSynthesizer (for all context cols, or all non-context columns)
4 participants