Improve error message when sampling on a non-CPU device #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
requested review from
rwedge and
pvk-developer
and removed request for
a team
sdv/single_table/base.py
Outdated
Comment on lines
495
to
502
| try: | ||
| synthesizer = cloudpickle.load(f) | ||
| except RuntimeError: | ||
| raise SamplingError( | ||
| 'This synthesizer was created on a machine with GPU but the current machine is' | ||
| ' CPU-only. This feature is currently unsupported. We recommend sampling on ' | ||
| 'the same GPU-enabled machine.' | ||
| ) |
There was a problem hiding this comment.
Shouldn't this occur on the sampling instead ? or the error gets raised while you load the synthesizer?
There was a problem hiding this comment.
From the user issue, they ran into this problem when loading the synthesizer, so that's where I added the warning.
pvk-developer
approved these changes
May 17, 2024
rwedge
reviewed
May 20, 2024
sdv/multi_table/base.py
Outdated
| try: | ||
| synthesizer = cloudpickle.load(f) | ||
| except RuntimeError: | ||
| raise SamplingError( |
There was a problem hiding this comment.
Could we only switch to the new error message after confirming the error that surfaced has that specific message about the current machine being CPU-only?
rwedge
reviewed
May 20, 2024
rwedge
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86azg7w2c, Resolve #1819.