Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising warning for visualize #1537

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Raising warning for visualize #1537

merged 1 commit into from
Aug 14, 2023

Conversation

amontanez24
Copy link
Contributor

@amontanez24 amontanez24 commented Aug 14, 2023

This PR is to make sure the FutureWarnings are properly raised for #1525

@amontanez24 amontanez24 requested a review from a team as a code owner August 14, 2023 00:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0433374) 96.40% compared to head (a6298a8) 96.40%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1537   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          49       49           
  Lines        3982     3982           
=======================================
  Hits         3839     3839           
  Misses        143      143           
Files Changed Coverage Δ
sdv/metadata/multi_table.py 99.40% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amontanez24 amontanez24 merged commit 52ac3be into master Aug 14, 2023
74 checks passed
@amontanez24 amontanez24 deleted the issue-1525-fix branch August 14, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants