Add SingleTableMetadata visualization #1535
Conversation
pvk-developer
requested review from
amontanez24 and
fealho
and removed request for
a team
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
+ Coverage 96.36% 96.39% +0.02%
==========================================
Files 49 49
Lines 3937 3965 +28
==========================================
+ Hits 3794 3822 +28
Misses 143 143
☔ View full report in Codecov by Sentry. |
sdv/metadata/single_table.py
Outdated
| @@ -477,6 +479,60 @@ def validate(self): | |||
| + '\n'.join([str(e) for e in errors]) | |||
| ) | |||
|
|
|||
| def visualize(self, show_table_details='full', output_filepath=None): | |||
| """Create a visualization of the multi-table dataset. | |||
sdv/metadata/single_table.py
Outdated
|
|
||
| Args: | ||
| show_table_details (str): | ||
| If 'full', show the column names, primary, alternate and sequence keys are all |
There was a problem hiding this comment.
remove show after If 'full'. Also, review the docstrings, they mention table_names when I don't think we have them for single_table.
Also, shouldn't None be an option?
There was a problem hiding this comment.
@npatki None is an option for the multi-table visualization but in that case all it shows is the table name. That doesn't really make sense in single-table so should it be an option or not?
There was a problem hiding this comment.
I did not add it because it didn't make sense (empty box ?) ... In multi table I see a point of None since you can see the diagram.
sdv/metadata/single_table.py
Outdated
|
|
||
| Args: | ||
| show_table_details (str): | ||
| If 'full', show the column names, primary, alternate and sequence keys are all |
There was a problem hiding this comment.
@npatki None is an option for the multi-table visualization but in that case all it shows is the table name. That doesn't really make sense in single-table so should it be an option or not?
pvk-developer
force-pushed
the
issue-1517-add-visualize-to-singletablemetadata
branch
from
b9e1438
to
1e8fd04
Compare
pvk-developer
deleted the
issue-1517-add-visualize-to-singletablemetadata
branch
Resolves #1517