Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'unknown' sdtype #1532

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Support 'unknown' sdtype #1532

merged 3 commits into from
Aug 25, 2023

Conversation

R-Palazzo
Copy link
Contributor

Resolve #1516

@R-Palazzo R-Palazzo requested a review from a team as a code owner August 7, 2023 14:13
@R-Palazzo R-Palazzo removed the request for review from a team August 7, 2023 14:13
frances-h
frances-h reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change the else case on line 149 that defaults to categorical now that we're adding the unknown sdtype?

@R-Palazzo
Copy link
Contributor Author

Should we also change the else case on line 149 that defaults to categorical now that we're adding the unknown sdtype?

Hi @frances-h, in which file is it? In this PR we change the metadata detection to detect unknown sdtype.

@R-Palazzo R-Palazzo closed this Aug 18, 2023
@R-Palazzo R-Palazzo reopened this Aug 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.32% 🎉

Comparison is base (123038e) 96.17% compared to head (b7a4791) 96.49%.

❗ Current head b7a4791 differs from pull request most recent head 90957fc. Consider uploading reports for the commit 90957fc to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@                   Coverage Diff                   @@
##           metadata-improvment    #1532      +/-   ##
=======================================================
+ Coverage                96.17%   96.49%   +0.32%     
=======================================================
  Files                       48       48              
  Lines                     4107     4028      -79     
=======================================================
- Hits                      3950     3887      -63     
+ Misses                     157      141      -16
Files Changed Coverage Δ
sdv/metadata/single_table.py 99.15% <ø> (-0.12%) ⬇️
sdv/data_processing/data_processor.py 97.62% <100.00%> (+0.58%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amontanez24
amontanez24 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@R-Palazzo R-Palazzo changed the base branch from master to metadata-improvment August 25, 2023 14:15
@R-Palazzo R-Palazzo merged commit fb301cb into metadata-improvment Aug 25, 2023
37 checks passed
@R-Palazzo R-Palazzo deleted the issue-1516-unknown-sdtype branch August 25, 2023 15:26
R-Palazzo added a commit that referenced this pull request Sep 5, 2023
@R-Palazzo
Support 'unknown' sdtype (#1532)
6605003 
* def support unknown

* add test

* not pii 2
R-Palazzo added a commit that referenced this pull request Sep 5, 2023
@R-Palazzo
Support 'unknown' sdtype (#1532)
18b1911 
* def support unknown

* add test

* not pii 2
amontanez24 pushed a commit that referenced this pull request Sep 19, 2023
@R-Palazzo @amontanez24
Support 'unknown' sdtype (#1532)
8bc8e02 
* def support unknown

* add test

* not pii 2
amontanez24 pushed a commit that referenced this pull request Sep 27, 2023
@R-Palazzo @amontanez24
Support 'unknown' sdtype (#1532)
0406def 
* def support unknown

* add test

* not pii 2
amontanez24 pushed a commit that referenced this pull request Sep 27, 2023
@R-Palazzo @amontanez24
Support 'unknown' sdtype (#1532)
7ef67b1 
* def support unknown

* add test

* not pii 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@frances-h frances-h frances-h approved these changes

@pvk-developer pvk-developer pvk-developer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support 'unknown' sdtype
5 participants
@R-Palazzo @codecov-commenter @amontanez24 @frances-h @pvk-developer