Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for python 3.11 #1496

Merged
merged 5 commits into from
Aug 13, 2023
Merged

Add support for python 3.11 #1496

merged 5 commits into from
Aug 13, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Jul 11, 2023

Resolve #1459.

@fealho
Copy link
Member Author

fealho commented Jul 11, 2023

PR is waiting on CTGAN, SDMetrics and DeepEcho releases with python 3.11.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.08% ⚠️

Comparison is base (387e9dd) 96.38% compared to head (402ba5d) 96.31%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   96.38%   96.31%   -0.08%     
==========================================
  Files          49       49              
  Lines        3958     3962       +4     
==========================================
+ Hits         3815     3816       +1     
- Misses        143      146       +3
Files Changed Coverage Δ
sdv/multi_table/hma.py 78.82% <16.66%> (-1.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review August 11, 2023 21:40
@fealho fealho requested a review from a team as a code owner August 11, 2023 21:40
@fealho fealho requested review from pvk-developer, amontanez24, a team and frances-h and removed request for a team and pvk-developer August 11, 2023 21:40
amontanez24
amontanez24 reviewed Aug 11, 2023
View reviewed changes
sdv/multi_table/hma.py Outdated
@@ -6,6 +6,7 @@

import numpy as np
import pandas as pd
from packaging import version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we avoid using packaging? It's not listed as an sdv dependency and is probably installed by one of the other libraries. It seems like matplotlib and plotly require it and those are also not direct dependencies for SDV

amontanez24
amontanez24 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

frances-h
frances-h approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@fealho fealho merged commit 604d462 into master Aug 13, 2023
37 checks passed
@fealho fealho deleted the issue-1459-py311 branch August 13, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@frances-h frances-h frances-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.11
4 participants
@fealho @codecov-commenter @amontanez24 @frances-h