Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constraints failing with datetime and None values #1481

Merged
merged 7 commits into from
Jul 5, 2023
Merged

Fix constraints failing with datetime and None values #1481

merged 7 commits into from
Jul 5, 2023

Conversation

pvk-developer
Copy link
Member

Resolves #1471

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.05 ⚠️

Comparison is base (9d5e86c) 96.33% compared to head (56eeccc) 96.28%.

❗ Current head 56eeccc differs from pull request most recent head e1eecba. Consider uploading reports for the commit e1eecba to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
- Coverage   96.33%   96.28%   -0.05%     
==========================================
  Files          49       49              
  Lines        3925     3931       +6     
==========================================
+ Hits         3781     3785       +4     
- Misses        144      146       +2
Impacted Files Coverage Δ
sdv/constraints/utils.py 100.00% <ø> (ø)
sdv/constraints/tabular.py 96.81% <83.33%> (-0.32%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pvk-developer pvk-developer marked this pull request as ready for review June 28, 2023 17:02
@pvk-developer pvk-developer requested a review from a team as a code owner June 28, 2023 17:02
@pvk-developer pvk-developer requested review from frances-h and amontanez24 and removed request for a team June 28, 2023 17:02
@pvk-developer pvk-developer force-pushed the issue-1471-inequality-fails-with-none-and-datetime branch from 45270e4 to ee2fe64 Compare June 30, 2023 15:59
frances-h
frances-h reviewed Jun 30, 2023
View reviewed changes
sdv/constraints/utils.py Outdated Show resolved Hide resolved
frances-h
frances-h approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

amontanez24
amontanez24 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvk-developer pvk-developer merged commit 750332c into master Jul 5, 2023
28 checks passed
@pvk-developer pvk-developer deleted the issue-1471-inequality-fails-with-none-and-datetime branch July 5, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@frances-h frances-h frances-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inequality fails with None and datetime
4 participants
@pvk-developer @codecov-commenter @amontanez24 @frances-h