Skip to content

Commit

Permalink
Do one slack message instead
Browse files Browse the repository at this point in the history
  • Loading branch information
pvk-developer committed Sep 20, 2024
1 parent 3269b8e commit de9b4ee
Showing 1 changed file with 15 additions and 17 deletions.
32 changes: 15 additions & 17 deletions tests/benchmark/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,21 +108,6 @@ def compare_previous_result_with_current():
'python_version': python_version,
})

slack_messages = []
if unsupported_dtypes:
slack_messages.append(':fire: New unsupported DTypes!')

if new_supported_dtypes:
slack_messages.append(':party_blob: New DTypes supported!')

if slack_messages:
slack_message = '\n'.join(slack_messages)
response = post_slack_message('sdv-alerts-debug', slack_message)

if not new_supported_dtypes and not unsupported_dtypes:
slack_message = ':dealwithit: No new changes to the DTypes in SDV.'
response = post_slack_message('sdv-alerts-debug', slack_message)

results = {
'unsupported_dtypes': pd.DataFrame(unsupported_dtypes),
'new_supported_dtypes': pd.DataFrame(new_supported_dtypes),
Expand Down Expand Up @@ -178,16 +163,29 @@ def compare_and_store_results_in_gdrive():

results = csv_handler.read('results/')
sorted_results = {}

slack_messages = []
for key, value in comparison_results.items():
if not value.empty:
sorted_results[key] = value
if key == 'unsupported_dtypes':
slack_messages.append(':fire: New unsupported DTypes!')
elif key == 'new_supported_dtypes':
slack_messages.append(':party_blob: New DTypes supported!')

if len(slack_messages) == 0:
slack_messages.append(':dealwithit: No new changes to the DTypes in SDV.')

for key, value in results.items():
sorted_results[key] = value

file_id = save_to_gdrive(GDRIVE_OUTPUT_FOLDER, sorted_results)
new_msg = f'See <https://docs.google.com/spreadsheets/d/{file_id}|dtypes summary and details>'
update_message('#sdv-alerts-debug', new_msg, response['ts'])

slack_messages.append(
f'See <https://docs.google.com/spreadsheets/d/{file_id}|dtypes summary and details>'
)
slack_message = '\n'.join(slack_messages)
response = post_slack_message('sdv-alerts-debug', slack_message)


if __name__ == '__main__':
Expand Down

0 comments on commit de9b4ee

Please sign in to comment.