Skip to content

Commit

Permalink
Use locales set in _table_parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
frances-h committed Sep 19, 2024
1 parent 0d422b8 commit 50d7f28
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
5 changes: 3 additions & 2 deletions sdv/multi_table/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,10 @@ def _set_temp_numpy_seed(self):
def _initialize_models(self):
with disable_single_table_logger():
for table_name, table_metadata in self.metadata.tables.items():
synthesizer_parameters = self._table_parameters.get(table_name, {})
synthesizer_parameters = {'locales': self.locales}
synthesizer_parameters.update(self._table_parameters.get(table_name, {}))
self._table_synthesizers[table_name] = self._synthesizer(
metadata=table_metadata, locales=self.locales, **synthesizer_parameters
metadata=table_metadata, **synthesizer_parameters
)
self._table_synthesizers[table_name]._data_processor.table_name = table_name

Expand Down
6 changes: 4 additions & 2 deletions tests/unit/multi_table/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ def test__initialize_models(self):
locales = ['en_CA', 'fr_CA']
instance = Mock()
instance._table_synthesizers = {}
instance._table_parameters = {'nesreca': {'default_distribution': 'gamma'}}
instance._table_parameters = {
'nesreca': {'default_distribution': 'gamma', 'locales': ['fr_CA', 'en_CA']},
}
instance.locales = locales
instance.metadata = get_multi_table_metadata()

Expand All @@ -57,7 +59,7 @@ def test__initialize_models(self):
call(
metadata=instance.metadata.tables['nesreca'],
default_distribution='gamma',
locales=locales,
locales=['fr_CA', 'en_CA'],
),
call(metadata=instance.metadata.tables['oseba'], locales=locales),
call(metadata=instance.metadata.tables['upravna_enota'], locales=locales),
Expand Down

0 comments on commit 50d7f28

Please sign in to comment.