Support Python 3.12 #386
Support Python 3.12 #386
Conversation
|
Task linked: CU-86ayu7232 Copulas - Support Python 3.12 #372 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
+ Coverage 86.87% 86.90% +0.02%
==========================================
Files 27 27
Lines 1791 1795 +4
==========================================
+ Hits 1556 1560 +4
Misses 235 235 ☔ View full report in Codecov by Sentry. |
fealho
force-pushed
the
issue-372-py12
branch
7 times, most recently
from
9986e23
to
dec486b
Compare
fealho
force-pushed
the
issue-372-py12
branch
5 times, most recently
from
bf41bf9
to
82fa8d0
Compare
fealho
requested review from
rwedge,
amontanez24,
pvk-developer and
frances-h
and removed request for
a team and
rwedge
pyproject.toml
Outdated
| "scipy>=1.9.2,<2;python_version>='3.10'", | ||
| "scipy>=1.9.2,<2;python_version>='3.10' and python_version<'3.12'", | ||
| "scipy>=1.12.0,<2;python_version>='3.12'", | ||
| 'setuptools<70', |
There was a problem hiding this comment.
If we are adding setuptools because the init file uses pkg_resources, I think we should just switch to importlib instead since pkg_resources is deprecated. @frances-h I remember we wanted to do this before but had to keep pkg_resources for some reason. Was it because of python 3.8 or 3.7?
There was a problem hiding this comment.
If I remember correctly it was Python 3.7 because importlib.metadata was added in Python 3.8.
| @@ -26,10 +26,10 @@ | |||
| "\n", | |||
| "warnings.filterwarnings('ignore')\n", | |||
| "\n", | |||
| "from sklearn.datasets import load_boston\n", | |||
| "from sklearn.datasets import load_diabetes\n", | |||
There was a problem hiding this comment.
we should probably rerun the notebook since the outputs will be different now
| "metadata": {}, | ||
| "outputs": [ | ||
| { | ||
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "0.574182672682398\n" | ||
| "0.010323153621473069\n" |
There was a problem hiding this comment.
why is the score so much worse on this dataset?
There was a problem hiding this comment.
Note that this score varies from 1 to negative infinity, and that training on the real data performs just as poorly, so I would guess it's simply a harder regression problem.
CU-86ayu7232, Resolve #372