docker: Add docker-compose.yml and modify Dockerfile #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angad-k
force-pushed
the
add-docker-compose
branch
from
0026478
to
dbcb018
Compare
adrijshikhar
requested changes
Feb 7, 2022
murex971
requested changes
Feb 8, 2022
adrijshikhar
requested changes
Feb 10, 2022
angad-k
force-pushed
the
add-docker-compose
branch
from
49ba3c8
to
e8f3f74
Compare
angad-k
force-pushed
the
add-docker-compose
branch
from
a1fbb38
to
8154bb5
Compare
adrijshikhar
requested changes
Feb 11, 2022
angad-k
force-pushed
the
add-docker-compose
branch
from
8653bff
to
d25c502
Compare
adrijshikhar
requested changes
Feb 16, 2022
Comment on lines
+13
to
+14
| password: password | ||
| db_name: pinger |
There was a problem hiding this comment.
use env variables here as we discussed with viper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies Dockerfile to actually run pinger instead of just running the
versioncommand. Adds a docker-compose.yml for easy startup.