Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Quote $SDKMAN_DIR in version subcommand #1245

Closed

Conversation

hyperupcall
Copy link

With this change, the version subcommand now works if $SDKMAN_DIR includes newlines, etc.

@marc0der
Copy link
Member

marc0der commented Oct 7, 2023

Hi @hyperupcall, the version subcommand has been obsolete for a long time and is replaced by the Rust equivalent over here:
https://github.com/sdkman/sdkman-cli-native/blob/master/src/bin/version/main.rs

If you are having issues with the version command, please have a conversation with us on Slack so we can raise an issue to fix it properly.

@hyperupcall
Copy link
Author

Thank you for your quick response! I see, the equivalent Rust code is always ran instead (assuming they use the installer and are on one of sdkman-cli-native's 5 supported architectures). In that case, I will close this issue since it doesn't actually change anythig. Maybe there can be a comment at the top or the file can be deleted to prevent confusions like this in the future

@hyperupcall hyperupcall closed this Oct 7, 2023
@hyperupcall hyperupcall deleted the hyperupcall-fix-sdkmandir-quote branch October 7, 2023 12:14
@marc0der
Copy link
Member

marc0der commented Oct 7, 2023

No probs, and do let me know if you have any issues. We'll probably begin removing these legacy files soon, but I'll update the project README with some more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants