Add support for Jackson annotations to determine visibility and names of properties. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2017 14:48
|
Cool! Will check asap. We should also think about supporting JSON-B (Java EE 8). |
|
+1 for that and to support JSON-B |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for Jackson annotations:
A runtime arg will determine whether JAXB (default) or Jackson is used.
Field/getter visibility rules and name resolution is entirely delegated to the Jackson library.
I also fixed an issue with one of the existing tests. Although the test appears to work by itself it leaves the JobRegistry.INSTANCE value as a mocked instance. This breaks a subsequent test but only if the other test is run after this test. In other words you might not always see the test failing. For example in Eclipse it worked fine but from commandline it failed for me.