Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail Readme (#2) #4

Merged
merged 21 commits into from
Aug 12, 2022
Merged

Detail Readme (#2) #4

merged 21 commits into from
Aug 12, 2022

Conversation

jqmcginnis
Copy link
Collaborator

@jqmcginnis jqmcginnis commented Jul 7, 2022

As described in NeuroPoly / TUM team meeting (06.06.2022),

we have progressed on the BIDSification of the dataset and have converted the stitching.py from python2 to python3.

For now, both scripts are in a working state but will be subject to change, as they are currently work in progress.

To have a working state, I propose to have the scripts in the master.

@jqmcginnis jqmcginnis mentioned this pull request Jul 7, 2022
3 tasks
@sandrinebedard sandrinebedard self-requested a review July 7, 2022 14:03
Copy link
Member

@sandrinebedard sandrinebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! However, I don't have de data to test it out (neither the instructions on how to use the scripts)

A suggestion for futur PRs, you can add a section in the PR body on how to test the script out.

@jqmcginnis jqmcginnis changed the title Feature/bidsification Detail Readme (#2) Aug 11, 2022
@jqmcginnis
Copy link
Collaborator Author

Hi @sandrinebedard,

I tried to address some of the aspects mentioned in issue #2, e.g. description of the pipeline and the data.
Towards the end of August (or at least in our next team meeting), I should be able to provide a dataset sample which you can use test the scripts. In the mean time, I would recommend merging this into the main branch, as the main branch's Readme.md is currently almost empty.

Let me know if you agree,

Julian

Copy link
Member

@sandrinebedard sandrinebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seams good to me if ou merge for the README.

@jqmcginnis jqmcginnis merged commit 88d0957 into main Aug 12, 2022
@jqmcginnis jqmcginnis deleted the feature/bidsification branch September 22, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants