Refactor the code structure #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silathdiir
force-pushed
the
rename-zkevm-crate-to-prover
branch
from
c4783ad
to
3bdf4e1
Compare
silathdiir
changed the title
zkevm crate to proverzkevm crate to prover
silathdiir
changed the title
zkevm crate to proverzkevm folder to prover
icemelon
reviewed
Jun 22, 2023
| @@ -19,6 +19,7 @@ pub use outer_proof::AggCircuitProof; | |||
| #[cfg(target_os = "linux")] | |||
| extern crate procfs; | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
@lispc should we remove OPT_MEM here given that it's not used anywhere?
There was a problem hiding this comment.
ok.. it was a feature when OPT_MEM enabled, release super circuit pk before start agg circuit proving. not needed now.
There was a problem hiding this comment.
Got it. So let's keep this line of code for now in case we may use it in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix affects other pending PRs which use or update
zkevmfolder.Summary
According to #145 and discussing with @icemelon , suppose to rename
zkevmcrate (and folder) toproverfirst (this PR), then work on this Asana task.Test
Clone new clean code and test with
make test-agg(could pass) on super.