Handle custom attributes received in the API response. #213
Conversation
|
Requires zytedata/zyte-common-items#100 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 97.69% 97.86% +0.16%
==========================================
Files 14 14
Lines 1564 1590 +26
Branches 330 337 +7
==========================================
+ Hits 1528 1556 +28
+ Misses 15 14 -1
+ Partials 21 20 -1
|
|
(some test failures related to field overrides) |
|
I’ll handle the update of since I am already refactoring it significantly as part of SERP work. |
scrapy_zyte_api/providers.py
Outdated
| k: ( | ||
| dict(v) | ||
| if isinstance(v, frozenset) | ||
| else list(v) if isinstance(v, tuple) else v | ||
| ) |
There was a problem hiding this comment.
this code seems to be copy-pasted - time to add a helper function? Is it something like undo_make_hashable?
There was a problem hiding this comment.
Done, and now I think both functions need tests. We don't actually test what we receive in mockserver requests.
There was a problem hiding this comment.
Makes sense, let's add a few tests!
|
We should release zyte-common-items before merging this I think. |
|
@wRAR feel free to merge when you think it's ready. |
No description provided.