Refactor spidermon.utils.zyte.Client to use crawler settings #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to test it to make sure it works properly |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 78.51% 78.52%
=======================================
Files 73 73
Lines 3151 3152 +1
Branches 528 528
=======================================
+ Hits 2474 2475 +1
Misses 600 600
Partials 77 77
☔ View full report in Codecov by Sentry. |
Gallaecio
approved these changes
Aug 11, 2023
|
Tests with unit tests and SC real jobs, it works as expected |
VMRuiz
added a commit
that referenced
this pull request
Aug 31, 2023
* Refactor spidermon.utils.zyte.Client to use crawler settings * Update monitors to instantiate Client objects * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410