Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: make AddLinkType acquire the DataPlane mutex #4614

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions router/dataplane.go
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,11 @@ func (d *DataPlane) AddNeighborIA(ifID uint16, remote addr.IA) error {
// the given ID is already set, this method will return an error. This can only
// be called on a not yet running dataplane.
func (d *DataPlane) AddLinkType(ifID uint16, linkTo topology.LinkType) error {
d.mtx.Lock()
defer d.mtx.Unlock()
if d.IsRunning() {
return modifyExisting
}
if _, exists := d.linkTypes[ifID]; exists {
return serrors.JoinNoStack(alreadySet, nil, "ifID", ifID)
}
Expand Down
Loading