ci: upload binaries as artifacts #4391
Conversation
matzf
force-pushed
the
buildkite-bin-artifacts
branch
5 times, most recently
from
10e39ca
to
ed2b9dd
Compare
Upload binaries built in the build step as build artifacts. Inlcudes some cleanup around the uploading of artifacts and related hooks. Now only the handling of the bazel-remote and go-module-proxy is left in the pre-command/pre-exit hooks. The rest is moved into step-specific metahook-hooks. The log artifacts are no longer combined into a single tar.gz. That has never seemed very convenient to me. Let's see if this works well.
matzf
force-pushed
the
buildkite-bin-artifacts
branch
from
64e0ccb
to
249b5eb
Compare
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @matzf)
README.md line 34 at r1 (raw file):
for instructions on how to install build dependencies, build and run SCION. Pre-built binaries for x86-64 Linux are also available from the [latest nightly build](https://buildkite.com/scionproto/scion-nightly/builds/latest).
"are available"
Code quote:
are also available.buildkite/pipeline.yml line 18 at r1 (raw file):
#### Build outputs - <a href="artifact://bazel-bin/scion.tar">SCION binaries</a> - <a href="artifact://bazel-bin/scion-ci.tar">SCION test tools and utilities binaries</a>
Just "SCION test tools and utilities"?
Code quote:
SCION test tools and utilities binaries
There was a problem hiding this comment.
Reviewable status: 5 of 7 files reviewed, all discussions resolved (waiting on @marcfrei)
README.md line 34 at r1 (raw file):
Previously, marcfrei (Marc Frei) wrote…
"are available"
Done.
.buildkite/pipeline.yml line 18 at r1 (raw file):
Previously, marcfrei (Marc Frei) wrote…
Just "SCION test tools and utilities"?
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
Upload binaries built in the build step as build artifacts.
Add a buildkite "annotation" to give quick access to these archive with these binaries.
Inlcudes some cleanup around the uploading of artifacts and related hooks.
Now only the handling of the bazel-remote and go-module-proxy is left in the pre-command/pre-exit hooks.
The rest is moved into step-specific metahook-hooks. This includes collecting the test outputs artifacts -- this is kept as archives instead of individual files, just because the number of individual test output files seems somewhat overwhelming in the buildkite UI.
This change is