Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slayers: unmap IPv4-mapped IPv6 addresses #4377

Merged
merged 3 commits into from
Oct 10, 2023
Merged

slayers: unmap IPv4-mapped IPv6 addresses #4377

merged 3 commits into from
Oct 10, 2023

Commits on Aug 16, 2023

  1. slayers: unmap IPv4-mapped IPv6 addresses 

    The Go standard library can produce IPv4-mapped IPv6 addresses when
resolving IP addresses. These IP addresses need to be unmapped before
putting them on the wire.

Before this patch, we could observe the following with tshark:

    Len=1304 SCION 1-ff00:0:110,[::ffff:172.20.2.2] -> 1-ff00:0:111,[::ffff:172.20.3.2] UDP 32769 -> 32768 1208

The regression was introduced in scionproto#4346, which removed the unmapping behavior
in slayers.PackAddr. This patch restores the behavior to ensure only
unmapped IPv4 addresses make it on the wire.
    @oncilla
    oncilla committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4069fad View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. simplify code

    @oncilla
    oncilla committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    7c8847d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Merge branch 'master' into slayers-unwrap

    @oncilla
    oncilla authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a4b9c76 View commit details
    Browse the repository at this point in the history