Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hiddenpaths registration work both locally and remotely #4376

Merged
merged 35 commits into from
Aug 29, 2023

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    0a5f12b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fb135b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9cd4df8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e2b8f7b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ecfb97c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    21e1da6 View commit details
    Browse the repository at this point in the history
  7. hidden_paths: A less disruptive solution to the registry addressing.

    * give the control service a static port.
    * use that in the topo config as the hidden_path service address for use by the discovery service.
    * This change does not yet include the associated changes to the config generators.
    jiceatscion committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ed60241 View commit details
    Browse the repository at this point in the history
  8. hidden_paths: Slight change of approach to address configuration.

    The CS public address and the CS scion address can now be the same, while the service resolver explicitly gets a different port.
    
    I am experimenting with the possibility of configuring the service resolver address as the regular address field of a new service named "service_resolution". (oncilla@ thinks it's a bad idea. I do not understand why yet but I guess I'll find out).
    
    Also updated tests to match the intended changes, and to call assert.Equal() with arguments in the correct order.
    jiceatscion committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ac6a9cd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    13f2f76 View commit details
    Browse the repository at this point in the history
  10. update mocks

    jiceatscion committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3ca68f6 View commit details
    Browse the repository at this point in the history
  11. resolver_service: Make the service resolution port dynamic by default.

    If the service resolution address isn't configured, let it have a random port.
    
    The dispatcher dynamically assigns a port and also registers it as the recipient of resolution requests. It appears that no knowledge of the port is required outside of that.
    jiceatscion committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    0c24724 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    91fcc94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b0983d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. hidden_paths: Simplifications - the Resolver address now always has a…

    … dynamic port.
    
    Doing this allows the CS's SCION address to have the same host/port as the CS's public address (by default) instead of being dynamic. This in turn makes it discoverable, which allows the hidden path registry to be reachable.
    
    This approach allows the topology file to declare the hidden_path registry address to be obviously identical to the address configured for the CS... much less confusing.
    jiceatscion committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    814522f View commit details
    Browse the repository at this point in the history
  2. hidden_paths: removed abadonned change. The ServiceResolution address…

    … doesn't need to be configurable.
    jiceatscion committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    189b687 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b70948 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    da7ab4f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eb032fa View commit details
    Browse the repository at this point in the history
  6. hidden_paths: use the new config appraoch in tests - hs services have…

    … the same address as cs.
    jiceatscion committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    cdd27dc View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    4d69965 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b79c8d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    925e924 View commit details
    Browse the repository at this point in the history
  4. hidden_paths: Simplified some more. Got rid of the IntraASTCPServer f…

    …or the hidden segment service. It's not needed. The local optimization has low value and won't be done at this time if ever.
    jiceatscion committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8fbea89 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. hidden_paths: Ensure that intraAS paths have metadata.

    This avoids the need for special behavior to handle nil metadata in a few places.
    jiceatscion committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    5376bc4 View commit details
    Browse the repository at this point in the history
  2. hidden_paths: remove the Interfaces method from the Path interface.

    This method isn't useful anymore. All paths which metadata gets used now have real metadata.
    jiceatscion committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    59e9b6c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f9d418 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    625def5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4fda540 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ac87cde View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d1e9dbd View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Configuration menu
    Copy the full SHA
    d7c8d15 View commit details
    Browse the repository at this point in the history
  2. hidden_paths: add an empty dataplanePath to intraAS paths so they are…

    … truly complete and safe to use.
    jiceatscion committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    deed435 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2373845 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3e92748 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    ca14667 View commit details
    Browse the repository at this point in the history